Usage

usage: java -jar cba-cli.jar [OPTIONS] -a DIRECTORY_TO_ANALYZE
  -a,--analyze <pathToAnalyze>    Path of the directory to run the
                                  analysis.
 -c,--checks <checks...>          Space separated list of custom checks
                                  that are going to be run in the analysis.
  -f,--custom-file <customFile>   Specify a file in JSON format to run
                                  custom rules. Read more in GitHub.
  -h,--help                       Print this message.
  -i,--items-report <maxItems>    Max number of items per report. If the
                                  number of issues found exceeds this
                                  value, the report will be split into
                                  different files. Useful if expecting too
                                  many issues in the report. Default: 500.
  -o,--output <outputDir>         Directory to save the report. Warning -
                                  if there are already saved reports in
                                  this directory they will be overwritten.
                                  Default is "report".
  -v,--verbose-debug              Increase verbosity to debug mode.
  -vv,--verbose-trace             Increase verbosity to trace mode.
 

Custom JSON rules
Rules file can be specified using -f,--custom-file argument . The file is in JSON format and has the following structure:

• rules : array(rule)
  • name : string
  • interfaces : array(string)
  • superClass : string
  • methods : array(method)
    • name : string
    • visibility : [public|protected|private]
    • parameter : string (only one parameter is supported at the moment)
    • report : boolean (default: true)
  • invocations : array(invocation)
    • owner : string
    • method : method
      • name : string
      • visibility : [public|protected|private]
      • parameter : string (only one parameter is supported at the moment)
    • notFrom : method
      • name : string
      • visibility : [public|protected|private]
      • parameter : string (only one parameter is supported at the moment)
    • from : method
      • name : string
      • visibility : [public|protected|private]
      • parameter : string (only one parameter is supported at the moment)
    • report : boolean (default:true)

You can also check net.nandgr.cba.custom.model.Rules.java to see the structure in Java code.

Examples

Find custom deserialization
If we need to find classes with custom deserialization, we can do it quite easily. A class defines custom deserialization by implementing private void readObject(ObjectInputStream in) . So we only need to find all classes where that method is defined. It would be enough just to define a rule as:

{
     "rules": [{
         "name": "Custom deserialization",
         "methods": [{
             "name": "readObject",
             "visibility": "private",
             "parameter": "java.io.ObjectOutputStream"
         }]
     }]
 }

It will report methods with private visibility, readObject as name and a parameter of type java.io.ObjectOutputStream . Since we only have one rule, a report named: custom-deserialization-0.html will be created.

Find custom serialization and deserialization
In this case, one rule with two methods have to be defined. The same one than in the previous example for deserialization, and a new one to match private void writeObject(ObjectOutputStream out) . As shown in the JSON structure above, the property rules.rule.methods is an array of methods, so a rule like this can be written:

{
     "rules": [{
         "name": "Custom serialization and deserialization",
         "methods": [{
             "name": "readObject",
             "visibility": "private",
             "parameter": "java.io.ObjectOutputStream"
         },{
             "name": "writeObject",
             "report": "false",
             "visibility": "private",
             "parameter": "java.io.ObjectOutputStream"
         }]
     }]
 }

The property report was set to false to avoid reporting twice for the same rule. We are using the second method just as a condition, but reporting only readObject methods should be enough for the example purpose.

Find all method definitions
If a property is not defined, it will always match as true. For example, this rule would return all methods definitions:

{
     "rules": [{
         "name": "Method definitions",
         "methods": [{
         }]
     }]
 }

Find String.equals method invocations
Method invocations can also be found. The JSON in this case would be:

{
     "rules": [{
         "name": "String equals",
         "invocations": [{
             "owner": "java.lang.String",
             "method": {
                 "name": "equals"
             }
         }]
     }]
 }

The property owner specifies the class containing the method.

Reflection method invoke
Another method invocation example a bit more useful than the previous one:

{
     "rules": [{
         "name": "Method invocation by reflection",
         "invocations": [{
             "owner": "java.lang.reflect.Method",
             "method": {
                 "name": "invoke"
             }
         }]
     }]
 }

Deserialization usage
In this example, we want to find deserialization usages (not classes defining serialization behaviors like in the previous examples). Deserialization happens when ObjectInputStream.readObject() is invoked. for example in this code snippet:

ObjectInputStream in = new ObjectInputStream(fileInputStream);
 Object o = in.readObject();

So we need to find method invocations from ObjectInputStream named readObject . But it will find a lot of false positives in a researching context, because when a class defines custom deserialization, they make an invocation to this method inside a private void readObject(ObjectInputStream in) method, and that would pollute the report too much. If we want to exclude those cases and keep only genuine deserialization, notFrom property can be used:

{
     "rules": [{
         "name": "Deserialization usage",
         "invocations": [{
             "owner": "java.io.ObjectInputStream",
             "method": {
                 "name": "readObject"
             },
             "notFrom": {
                 "name": "readObject",
                 "visibility": "private",
                 "parameter": "java.io.ObjectInputStream"
             },
             "report": true
         }]
     }]
 }

This file will find java.io.ObjectInputStream.readObject() invocations if the invocation is not done inside private void readObject(ObjectInputStream in) method.
A class compiled with this code will not be reported:

private void readObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
       Object o = in.readObject();
 }

But this one will be reported:

public Object deserializeObject(ObjectInputStream in) throws IOException, ClassNotFoundException {
       Object o = in.readObject();
       return o;
 }

The property from can be set in invocations in exactly the same way than notFrom , but the result will be the opposite: it will only match if the invocation is made from the defined method.

Java servlets
The property superClass can be used in this case. If we want to find all classes extending javax.servlet.http.HttpServlet , a rule can be:

{
         "rules": [{
                 "name": "Java servlets",
                 "superClass" : "javax.servlet.http.HttpServlet"
         }]
 }
 

X509TrustManager implementations
A rule can be written to find classes implementing an array of interfaces. if more than one interface is defined in the rule, the class has to implement all of them to be reported. If we want to find classes implementing javax.net.ssl.X509TrustManager , the rule would be:

{
         "rules": [{
                 "name": "X509TrustManager implementations",
                 "interfaces" : ["javax.net.ssl.X509TrustManager"]
         }]
 }
 

Please note that interfaces is an array , so make sure you add the strings between square brackets, e.g: ["interface1", "interface2", ...] .

Define multiple rules
Multiple rules can be defined in the same JSON file. They will be processed and reported separately and they will not affect each other. We can combine some of the previous examples rules:

{
     "rules": [{
         "name": "Custom deserialization",
         "methods": [{
             "name": "readObject",
             "visibility": "private",
             "parameter": "java.io.ObjectOutputStream"
         }]
     },{
         "name": "Method invocation by reflection",
         "invocations": [{
             "owner": "java.lang.reflect.Method",
             "method": {
                 "name": "invoke"
             }
         }]
     }]
 }

Here, we have two rules ("Custom deserialization" and "Method invocation by reflection"). They will be processed as if you do it in two separated executions. And a report per rule will be generated.

Custom Java rules
The project can be downloaded and built to add more complex custom rules in Java code that are not covered by the JSON format. There are already three examples under the package net.nandgr.cba.visitor.checks . Those are CustomDeserializationCheck, DeserializationCheck and InvokeMethodCheck . You can create your own rules by extending net.nandgr.cba.custom.visitor.CustomAbstractVisitor . CustomAbstractVisitor is extending ASM org.objectweb.asm.ClassVisitor , so plenty of documentation can be found in the internet about it.

Command line examples

Run an analysis using a JSON file

java -jar cba-cli-<version>.jar -a /path/with/jars -f /path/with/json/file/rules.json

Run an analysis using a Java custom rule
To use custom java rules, class names have to be specified as arguments of -c .

java -jar cba-cli-<version>.jar -a /path/with/jars -c DeserializationCheck

Accepts a space separated list, so multiple custom rules can be defined (each of the rules will create a separate report):

java -jar cba-cli-<version>.jar -a /path/with/jars -c DeserializationCheck InvokeMethodCheck CustomDeserializationCheck YourCustomRule

Combine JSON and custom Java rules

java -jar cba-cli-<version>.jar -a /path/with/jars -f /path/with/json/file/rules.json -c YourCustomRule1 YourCustomRule2

Increase verbosity
To find errors, verbosity can be increased. Debug level:

java -jar cba-cli-<version>.jar -a /path/with/jars -c YourCustomRule1 -v

Trace level:

java -jar cba-cli-<version>.jar -a /path/with/jars -c YourCustomRule1 -vv

Build and run the project
There is already an executable jar file under bin directory at: https://github.com/fergarrui/custom-bytecode-analyzer/blob/master/bin/cba-cli-0.1-SNAPSHOT.jar . If you want to do modifications or add custom rules, the project can be built doing:

git clone https://github.com/fergarrui/custom-bytecode-analyzer.git
 cd custom-bytecode-analyzer
 mvn clean package

Two jars will be generated under target folder. cba-cli-<version>.jar contains all dependencies and is executable. Can be run using java -jar cba-cli-<version>.jar